FileBrowserHelper.getFileDetailInfo: Support more refined filtering#2668
Merged
XingY merged 1 commit intorelease25.9-SNAPSHOTfrom Sep 5, 2025
Merged
FileBrowserHelper.getFileDetailInfo: Support more refined filtering#2668XingY merged 1 commit intorelease25.9-SNAPSHOTfrom
XingY merged 1 commit intorelease25.9-SNAPSHOTfrom
Conversation
XingY
approved these changes
Sep 3, 2025
|
|
||
| // "RelativeFolder" is not a filterable column on the query table | ||
| if (relativeFolder != null) | ||
| fileInfos = fileInfos.stream().filter(f -> relativeFolder.equals(f.relativeFolder)).toList(); |
Contributor
There was a problem hiding this comment.
Maybe case insensitive check? Also is it worth checking with leading and trailing "/" ignored?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The recently added
FileBrowserHelper.getFileDetailInfo()test utility now supports more filtering mechanisms. With this we can refine our test scenarios to find the exact file expected.Related Pull Requests
Changes
getFileDetailInfo()to: